-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons management #274
Icons management #274
Conversation
This pull request is being automatically deployed with Vercel (learn more). docs – ./docs🔍 Inspect: https://vercel.com/relayed/docs/p3JNz6zrYEQeoVnD7tQv1sbqM8t3 [Deployment for 93f5507 canceled] storybook – ./🔍 Inspect: https://vercel.com/relayed/storybook/BHZgSJPPcixQgCYv1UTiovcU2eFn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! a small note about the removed dependency, is that needed?
apps/web/package.json
Outdated
@@ -73,7 +73,6 @@ | |||
"@storybook/addon-essentials": "^6.4.14", | |||
"@storybook/addon-links": "^6.4.14", | |||
"@storybook/node-logger": "^6.4.14", | |||
"@storybook/preset-create-react-app": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ainouzgali is this not needed anymore? From what I remember it's need to render the react storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i reverted this :) you are right
No description provided.