Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons management #274

Merged
merged 6 commits into from
Feb 20, 2022
Merged

Icons management #274

merged 6 commits into from
Feb 20, 2022

Conversation

ainouzgali
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Feb 20, 2022

RLD-119 Icons Management

Create an Icons library

@gitpod-io
Copy link

gitpod-io bot commented Feb 20, 2022

@vercel
Copy link

vercel bot commented Feb 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./docs

🔍 Inspect: https://vercel.com/relayed/docs/p3JNz6zrYEQeoVnD7tQv1sbqM8t3
✅ Preview: Canceled

[Deployment for 93f5507 canceled]

storybook – ./

🔍 Inspect: https://vercel.com/relayed/storybook/BHZgSJPPcixQgCYv1UTiovcU2eFn
✅ Preview: https://storybook-git-rld-119-icons-management-relayed.vercel.app

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! a small note about the removed dependency, is that needed?

@@ -73,7 +73,6 @@
"@storybook/addon-essentials": "^6.4.14",
"@storybook/addon-links": "^6.4.14",
"@storybook/node-logger": "^6.4.14",
"@storybook/preset-create-react-app": "^4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ainouzgali is this not needed anymore? From what I remember it's need to render the react storybook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reverted this :) you are right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants